Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change test_array_backends mixin classes to subclass QiskitDynamicsTestCase #272

Merged

Conversation

DanPuzzuoli
Copy link
Collaborator

@DanPuzzuoli DanPuzzuoli commented Oct 17, 2023

Summary

Changes the classes utilized by test_array_backends to be subclasses of QiskitDynamicsTestCase. The arraylias module tests have also been updated (this is the only test folder that currently uses this).

Details and comments

@DanPuzzuoli DanPuzzuoli requested a review from to24toro October 17, 2023 15:27
@to24toro to24toro self-requested a review October 18, 2023 10:43
@to24toro
Copy link
Contributor

A modification where Arraytest inherits QiskitDynamicsTestCase caused a no-member error in the existing tests that inherits QiskitDynamicsTestCase since the method of QiskitDynamicsTestCase is not found in the tests.(e.g. self.assertAllClose()). At least, I believe we have to acknowledge this error.

It might be good to provide a means of Arraylais to make tests for some arrays work.

@DanPuzzuoli DanPuzzuoli merged commit 3a373cf into qiskit-community:main Oct 18, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants