This repository has been archived by the owner on Dec 7, 2021. It is now read-only.
QSVM L2 Reg. introduction for convergence and over-fitting issue #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sternparky
requested review from
levbishop,
manoelmarques and
woodsp-ibm
as code owners
|
|
sternparky
changed the title
woodsp-ibm
added
Changelog: Bugfix
woodsp-ibm
approved these changes
Oct 23, 2020
manoelmarques
pushed a commit
to manoelmarques/qiskit-aqua
that referenced
this pull request
Nov 9, 2020
…kit-community#1378) * First update on qp_solver with L2 * Update test for lambda2 * Add reno Co-authored-by: woodsp <[email protected]> Co-authored-by: Steve Wood <[email protected]>
manoelmarques
pushed a commit
to qiskit-community/qiskit-machine-learning
that referenced
this pull request
Feb 27, 2021
…kit-community/qiskit-aqua#1378) * First update on qp_solver with L2 * Update test for lambda2 * Add reno Co-authored-by: woodsp <[email protected]> Co-authored-by: Steve Wood <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We have made updates on qsvm_binary file and associated files to implement L2 regularization.
Fixes #1334 : ValueError in qp_solver.py
Details and comments
Lambda2 parameter was introduced and set at "0,001" which will eliminate the convergence issue for different feature_maps
also, if Lambda2 is set at "0", then it will reproduce the previous result by disenabling L2 reg.
Two benefits ( a) Convergence issue related to ValueError in qp_solver.py #1334 (b) Over-fitting issue