Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Win CI max ver to 3.12 now Aer supports 3.12 #130

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

woodsp-ibm
Copy link
Member

@woodsp-ibm woodsp-ibm commented Jan 18, 2024

Summary

Qiskit Aer recently released 0.13.2 which now supports Python 3.12 so that wheels are available and it does not need to get built locally. This allows up to bump the Windows CI max Python version in which we test from 3.11 to 3.12 to be the same as Ubuntu and MacOS.

Resolves #109

Details and comments

While this changed to 3.12 it is actually specifically 3.12.0 (same as other platforms) until #113 is addressed (i.e. when an updated testtools is released).

This will require branch rules to be updated since the Required Win 3.11 job will no longer happen with this change. i.e.

  • Algorithms (windows-latest, 3.11): Remove
  • Algorithms (windows-latest, 3.12.0): Make Required

@coveralls
Copy link

Pull Request Test Coverage Report for Build 7575920732

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.578%

Totals Coverage Status
Change from base Build 7561091012: 0.0%
Covered Lines: 6470
Relevant Lines: 7143

💛 - Coveralls

Copy link
Collaborator

@ElePT ElePT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! changed the main branch protection rules to require windows-latest, 3.12.0 instead of windows-latest, 3.11

@ElePT ElePT merged commit 5ad174a into qiskit-community:main Jan 19, 2024
18 checks passed
@woodsp-ibm woodsp-ibm deleted the win_to_3.12 branch January 19, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Win CI Python max version too 3.12 when Aer releases 3.12 supported wheels
3 participants