prevent crash in logger when no message

qiscus · Dec 1, 2020 · 8236543 · 8236543
1 parent 8b1efea
commit 8236543
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 5 deletions.
diff --git a/README.md b/README.md
@@ -54,7 +54,7 @@ Second, you need to add SDK dependencies inside your app .gradle. Then, you need
 ```
 dependencies { 
        ... 
-       implementation 'com.qiscus.sdk:chat-core:1.3.24'
+       implementation 'com.qiscus.sdk:chat-core:1.3.25'
 }
 ```
 

diff --git a/chat-core/src/main/java/com/qiscus/sdk/chat/core/util/QiscusErrorLogger.java b/chat-core/src/main/java/com/qiscus/sdk/chat/core/util/QiscusErrorLogger.java
@@ -39,13 +39,21 @@ public final class QiscusErrorLogger {
 
     public static void print(Throwable throwable) {
         if (QiscusCore.getChatConfig().isEnableLog()) {
-            Log.e(TAG, getMessage(throwable));
+            try {
+                Log.e(TAG, getMessage(throwable));
+            } catch (NullPointerException n) {
+                Log.e(TAG, "error with no message");
+            }
         }
     }
 
     public static void print(String tag, Throwable throwable) {
         if (QiscusCore.getChatConfig().isEnableLog()) {
-            Log.e(tag, getMessage(throwable));
+            try {
+                Log.e(tag, getMessage(throwable));
+            } catch (NullPointerException n) {
+                Log.e(tag, "error with no message");
+            }
         }
     }
 

diff --git a/docs/index.md b/docs/index.md
@@ -80,7 +80,7 @@ Secondly, you need to add SDK dependencies inside your app .gradle. Then, you ne
 ```
 dependencies {
     ...
-    implementation 'com.qiscus.sdk:chat-core:1.3.24'
+    implementation 'com.qiscus.sdk:chat-core:1.3.25'
 }
 ```
 

diff --git a/gradle.properties b/gradle.properties
@@ -41,7 +41,7 @@ chatVersionPatch=17
 # === qiscus chat-core library version ===
 chatCoreVersionMajor=1
 chatCoreVersionMinor=3
-chatCoreVersionPatch=24
+chatCoreVersionPatch=25
 
 # === qiscus default base url
 BASE_URL_SERVER="https://api.qiscus.com/"
-Original file line number
+Diff line change
@@ Expand Up @@
     ```
     dependencies {
            ...
-           implementation 'com.qiscus.sdk:chat-core:1.3.24'
+           implementation 'com.qiscus.sdk:chat-core:1.3.25'
     }
     ```
@@ Expand Down @@