Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commands related to maturin in building docs #301

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

gschurck
Copy link
Contributor

This PR fixes two things in the building docs :

  • Documentation suggests to install latest maturin version, but the version pinned in pyproject.toml is ~=1.4.0, resulting in this warning :
    ⚠️  Warning: You specified maturin ~=1.4.0 in pyproject.toml under `build-system.requires`, but the current maturin version is 1.7.6
    
  • Build commands in docs use --cargo-extra-args option but it is removed since version O.13 :
    ❯ maturin build --cargo-extra-args="--features llvm14-0"
    error: unexpected argument '--cargo-extra-args' found
    
      tip: a similar argument exists: '--target'
    
    Usage: maturin build <--quiet|--jobs <N>|--profile <PROFILE-NAME>|--features <FEATURES>|--all-features|--no-default-features|--target <TRIPLE>|--target-dir <DIRECTORY>|--manifest-path <PATH>|--ignore-rust-version|--verbose...|--color <WHEN>|--frozen|--locked|--offline|--config <KEY=VALUE>|-Z <FLAG>|--timings=<FMTS>|--future-incompat-report|ARGS>
    
    For more information, try '--help'.
    

@swernli
Copy link
Collaborator

swernli commented Dec 2, 2024

@microsoft-github-policy-service rerun

@swernli swernli merged commit 7d4261d into qir-alliance:main Dec 2, 2024
12 checks passed
@gschurck gschurck deleted the docs/fix-maturin-commands branch December 2, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants