Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link function to Module #293

Merged
merged 13 commits into from
Sep 16, 2024
Merged

Add link function to Module #293

merged 13 commits into from
Sep 16, 2024

Conversation

idavis
Copy link
Collaborator

@idavis idavis commented Sep 13, 2024

Closes #285
Created and fixes issue #296 for better error messages with LLVMLinkModules2

@idavis idavis requested a review from cesarzc September 13, 2024 19:29
@idavis idavis self-assigned this Sep 13, 2024
@idavis idavis requested review from swernli and removed request for swernli September 13, 2024 19:29
@idavis idavis force-pushed the iadavis/module-link branch from 337f3a7 to 5943769 Compare September 16, 2024 15:58
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, one minor test suggestion (pun intended).

@idavis idavis merged commit feeef97 into main Sep 16, 2024
15 checks passed
@idavis idavis deleted the iadavis/module-link branch September 16, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API to merge QIR modules
2 participants