Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e without availability #157

Merged
merged 9 commits into from
May 28, 2024
Merged

Conversation

ziiiki
Copy link
Collaborator

@ziiiki ziiiki commented May 27, 2024

  • remove device availability from the code
  • delete e2e related to device availability
  • delete qiboconnection api methods block_device() and release_device()

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.56%. Comparing base (2549758) to head (343a28b).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   90.15%   91.56%   +1.41%     
==========================================
  Files          53       51       -2     
  Lines        1452     1352     -100     
==========================================
- Hits         1309     1238      -71     
+ Misses        143      114      -29     
Flag Coverage Δ
unittests 91.56% <100.00%> (+1.41%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ziiiki ziiiki requested review from islegmar, JavierSab and DZPM May 27, 2024 17:34
@ziiiki ziiiki self-assigned this May 27, 2024
@ziiiki ziiiki marked this pull request as draft May 27, 2024 17:42
@ziiiki ziiiki marked this pull request as ready for review May 27, 2024 17:42
@ziiiki ziiiki marked this pull request as draft May 28, 2024 06:21
@ziiiki ziiiki marked this pull request as ready for review May 28, 2024 06:21
@ziiiki ziiiki marked this pull request as draft May 28, 2024 06:50
@ziiiki ziiiki marked this pull request as ready for review May 28, 2024 06:50
@islegmar islegmar marked this pull request as draft May 28, 2024 11:14
@islegmar islegmar marked this pull request as ready for review May 28, 2024 11:15
@islegmar islegmar marked this pull request as draft May 28, 2024 11:21
@islegmar islegmar marked this pull request as ready for review May 28, 2024 11:21
Copy link

@DZPM DZPM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ziiiki ziiiki merged commit f3f71b0 into main May 28, 2024
7 checks passed
@ziiiki ziiiki deleted the refactor/device-status-and-availability branch May 28, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants