HACK: fix List[Bool] types (found by mystery-stew) #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looked into this a bit more, the edits to community comments in the initial change by maintainers in pallets/click#2248 are a little surprising to me. They don't appear disrespectful, but do note that the breaking change was unusual for a point release, which is generally true, although perhaps Pallet's projects don't follow the usual convention (we certainly don't). Still, I find it unsettling to edit out their specific objections. |
|
If click explodes, it's my fault. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click is really ending up as a mess for us. We've already gutted a ton of the original source by this point. How much more can it take?
pallets/click#2293