feat: 使用qrcode-svg替换qrcode #1565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to a Personal Account owned by @qier222 on Vercel. @qier222 first needs to authorize it. |
pan93412
requested changes
Apr 26, 2022
src/views/loginAccount.vue
Outdated
| <div | ||
| v-show="qrCodeSvg" | ||
| class="qr-code-container" | ||
| v-html="qrCodeSvg" |
There was a problem hiding this comment.
这个包没办法，输出就是一个完整的svg标签
There was a problem hiding this comment.
用了一个比较脏的做法避免 v-html，请review
|
🌚 還是 v-html 好了⋯⋯ |
把这个包fork一份改一下？我想在v2里也用这个，v2里有主题色的修改，每次重新生成新的svg感觉不太合适 |
|
现在我测试是没有问题了，但是这个库有一个潜在的问题，它的样式是写在svg的 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.