Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add copy track link & fixed various visual defects #1489

Merged
merged 6 commits into from
Apr 12, 2022

Conversation

GalvinGao
Copy link
Contributor

No description provided.

@vercel
Copy link

vercel bot commented Apr 6, 2022

Someone is attempting to deploy a commit to a Personal Account owned by @qier222 on Vercel.

@qier222 first needs to authorize it.

@memorydream
Copy link
Collaborator

能补充一下其他语言的翻译吗?

@GalvinGao
Copy link
Contributor Author

能补充一下其他语言的翻译吗?

@memorydream 检查了下,已有 copyUrlcopied,于是删除了重复定义;fixed in bacd4df

@qier222 qier222 requested review from pan93412 and memorydream April 8, 2022 16:20
src/utils/Player.js Outdated Show resolved Hide resolved
src/utils/Player.js Outdated Show resolved Hide resolved
@GalvinGao
Copy link
Contributor Author

By the way, I saw that restyled throw a PR at #1490. Should I incorporate those changes in my PR?

@GalvinGao
Copy link
Contributor Author

To be mention that I've already run the linters so that is kinda unexpected to me as they should've already been linted :D

@memorydream
Copy link
Collaborator

By the way, I saw that restyled throw a PR at #1490. Should I incorporate those changes in my PR?

no, i will close it

@GalvinGao
Copy link
Contributor Author

Lmao the restyled popped again. My bad. I intended to put cf1ed7a (#1489) in a separated PR though...

@qier222
Copy link
Owner

qier222 commented Apr 11, 2022

能否提供下更改前后的效果图?

@GalvinGao
Copy link
Contributor Author

GalvinGao commented Apr 11, 2022

主要是几处:

加入复制链接功能、以及弹窗的圆角半径修复为同心圆

image

Explicit Symbol 视觉上居中对齐

image

听歌排行的选择状态

image

以及多个作者时的逗号和空格的排版

image

唔 电脑上没有安装旧版 😢 所以没有修改前的对比图

@qier222 qier222 merged commit ea4b207 into qier222:master Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants