-
Notifications
You must be signed in to change notification settings - Fork 0
upgrading tensorflow to 2.5.0 #6
Conversation
Codecov Report
@@ Coverage Diff @@
## main #6 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 3 -1
Lines 371 371
=========================================
Hits 371 371
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update, looks good. Just one comment below:
Also noting that I have not been able to install tf2.5 on my local machine yet. After upgrading with pip, when I try to import tensorflow I get an error:
tensorflow.python.framework.errors_impl.NotFoundError: /home/stavros/.local/lib/python3.8/site-packages/tensorflow/core/kernels/libtfkernel_sobol_op.so: undefined symbol: _ZN10tensorflow6thread10ThreadPool26TransformRangeConcurrentlyExxRKSt8functionIFvxxEE
src/qibotf/custom_operators/python/ops/qibo_tf_custom_operators.py
Outdated
Show resolved
Hide resolved
allowing tensorflow version flexibility when installing from source
@stavros11 shall we merge this and release 0.0.2? |
I was finally able to install tf2.5 with pip in a clean environment and check. Everything seems to work both with 2.4.1 and 2.5 and I get the proper error messages if I try to use the custom operators compiled with a different version. I think we can merge. |
Perfect, thanks for the confirmation. |
In this PR: