Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

upgrading tensorflow to 2.5.0 #6

Merged
merged 11 commits into from
May 18, 2021
Merged

upgrading tensorflow to 2.5.0 #6

merged 11 commits into from
May 18, 2021

Conversation

scarrazza
Copy link
Member

In this PR:

  • upgrade requirement from 2.4.1 to 2.5.0
  • include version checks, in order to tell the user what is wrong.
  • extend python tests and wheels to python3.9
  • updated readme with compatibility table.

@scarrazza scarrazza requested a review from stavros11 May 16, 2021 09:22
@codecov
Copy link

codecov bot commented May 16, 2021

Codecov Report

Merging #6 (f9c584b) into main (fe67ca9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #6   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         3    -1     
  Lines          371       371           
=========================================
  Hits           371       371           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...m_operators/python/ops/qibo_tf_custom_operators.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe67ca9...f9c584b. Read the comment docs.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good. Just one comment below:

Also noting that I have not been able to install tf2.5 on my local machine yet. After upgrading with pip, when I try to import tensorflow I get an error:

tensorflow.python.framework.errors_impl.NotFoundError: /home/stavros/.local/lib/python3.8/site-packages/tensorflow/core/kernels/libtfkernel_sobol_op.so: undefined symbol: _ZN10tensorflow6thread10ThreadPool26TransformRangeConcurrentlyExxRKSt8functionIFvxxEE

@scarrazza
Copy link
Member Author

@stavros11 shall we merge this and release 0.0.2?

@stavros11
Copy link
Member

@stavros11 shall we merge this and release 0.0.2?

I was finally able to install tf2.5 with pip in a clean environment and check. Everything seems to work both with 2.4.1 and 2.5 and I get the proper error messages if I try to use the custom operators compiled with a different version. I think we can merge.

@scarrazza
Copy link
Member Author

Perfect, thanks for the confirmation.

@scarrazza scarrazza merged commit 5c13f66 into main May 18, 2021
@scarrazza scarrazza deleted the tf250 branch June 1, 2021 16:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants