Skip to content
This repository has been archived by the owner on May 19, 2022. It is now read-only.

adding make clean before build #22

Merged
merged 1 commit into from
Feb 11, 2022
Merged

adding make clean before build #22

merged 1 commit into from
Feb 11, 2022

Conversation

scarrazza
Copy link
Member

Forces clean before build. @andrea-pasquale could you please give a try?

@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #22 (4e75a86) into tf28 (636bbee) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              tf28       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          528       528           
=========================================
  Hits           528       528           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 636bbee...4e75a86. Read the comment docs.

Copy link

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this implementation.
On my machine it is working, I did a check in a previous env which was giving me the abort and now it is working fine.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also tried installing with pip install -e . in two different enviroments and tests works in both without having to recompile.

@scarrazza scarrazza merged commit 149a6b1 into tf28 Feb 11, 2022
@scarrazza scarrazza deleted the makeclean branch February 11, 2022 17:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants