-
Notifications
You must be signed in to change notification settings - Fork 0
Add TensorflowCustomBackend
class from qibo
#12
Conversation
@stavros11 thanks for this. Indeed, for this repository we need the requirements, given that tensorflow must be installed before running setup.py, and we use that file for the versioning control. |
This reverts commit fa4ba31.
Codecov Report
@@ Coverage Diff @@
## main #12 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 3 5 +2
Lines 371 528 +157
==========================================
+ Hits 371 528 +157
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@scarrazza, following what we discussed I removed the qibo requirement for testing. I also had to remove qibo from the |
@stavros11 thanks. No, I think this is related to auditwheels/py36. |
fixing wheels
updating tf version to 2.6.1
I added some tests for @scarrazza, do you have any idea why pylint is failing here? |
Should be the incompatibility you have fixed here: 024c165 |
I am giving this another try but I believe this results to some other installation issues. |
@stavros11 just fixed now. |
Thanks for the fix. This should be good to go, we just need to remember to reset the CI to |
@stavros11 thanks, I am looking into py36 right now. The major issue we have is that some qibo dependency is asking for matplotlib 3.4 which is not compatible with py36, I am not sure which package is forcing that version, however if we can get rid or disable this requirement for qibo then we can retry this PR with an updated version of the backendcls branch. |
I believe the py36 issue disappears if I install qibo using |
Ok, I will have another look, the problem was raised from https://github.com/qiboteam/qibotf/runs/4092821511?check_suite_focus=true#step:5:235. On the other hand looks like keras-2.7.0 is breaking the actions for qibo https://github.com/qiboteam/qibo/actions/runs/1421436395. If pinning down to 2.6.0 works then we will have to include this requirement here. |
upgrading tf to 2.6.2
Following qiboteam/qibo#500 this adds the
TensorflowCustomBackend
that was previously in qibo here. Since this class inherits the AbstractBackend from qibo, qibo is now added in the requirements list for qibotf.@scarrazza I tried removing the requirements.txt similarly to what you did for qibo and qibojit but there seems to be an issue here. Is there another reason this file is required here? If yes, I will put it back and just add the qibo requirement there.