Change .ravel()
back to .flatten()
for gates
#79
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of qibojit fails when running multigpu circuits on a machine with multiple physical GPUs. For example the following minimal example:
fails with
After checking earlier qibojit versions I realized that the error is associated with #74 and particularly because
.flatten()
was changed to.ravel()
for some gate castings. This is fixed here and the above example works. Also, all tests are passing.@scarrazza @andrea-pasquale, if you have access to a machine with multiple physical GPUs it would be good if you could check if the latest qibojit main gives you the above error and confirm that this PR fixes it. I found this while running the qibo tests on DGX. Note that the machine needs to have at least two GPUs, if there is only one (or the second GPU is hidden with CUDA_VISIBLE_DEVICES) then the error will not appear.