Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix in resonator flux dependence #998

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Conversation

Edoardo-Pedicillo
Copy link
Contributor

@Edoardo-Pedicillo Edoardo-Pedicillo commented Oct 2, 2024

  • coupling unit conversion
  • update fix

http://login.qrccluster.com:9000/I83qd7qkTzOTWnvl_VOBKA==/

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

@Edoardo-Pedicillo Edoardo-Pedicillo added this to the Qibocal 0.1.1 milestone Oct 3, 2024
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.50%. Comparing base (c77f563) to head (8911e60).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #998      +/-   ##
==========================================
- Coverage   97.56%   97.50%   -0.06%     
==========================================
  Files         123      123              
  Lines        9714     9713       -1     
==========================================
- Hits         9477     9471       -6     
- Misses        237      242       +5     
Flag Coverage Δ
unittests 97.50% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...l/protocols/flux_dependence/resonator_crosstalk.py 97.38% <100.00%> (+1.30%) ⬆️
...ocols/flux_dependence/resonator_flux_dependence.py 98.26% <100.00%> (-0.02%) ⬇️

... and 3 files with indirect coverage changes

@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review October 7, 2024 11:09
@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 6789ac8 Oct 9, 2024
21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the coupling_hz branch October 9, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants