-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sweeper types #369
Add sweeper types #369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @rodolfocarobene, LGTM.
I can confirm you that attenuation is swept using absolute values.
For the future we could also think about passing this sweeper type directly as an argument of the protocol to give more freedom to the user as we were discussing yesterday.
Btw, if you want to see if tests are passing here you can change the qibolab branch in the pyproject.toml and then regenerate the new lock file using poetry lock
.
I dismissed the review because the tests are not passing |
I think that this is expected since the current lock file is using qibolab main where |
Locally everything is passing, but before merging qibolab needs to be updated so this can wait a bit more. |
@andrea-pasquale @Edoardo-Pedicillo, this PR should be know ready for review and mergable (since we merged the qibolab PR). Here I broke almost all the niGSC tests when updating the lock file (in particular using latest version of qibo 0.0.14)... |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #369 +/- ##
==========================================
- Coverage 54.12% 54.11% -0.01%
==========================================
Files 68 68
Lines 5367 5366 -1
==========================================
- Hits 2905 2904 -1
Misses 2462 2462
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The issue with niGSC tests is solved in #380, that was merged in main. Merging the |
You are right, I thought to have merged main but I forgot to pull... sorry! |
Sweepers type (factor, offset, absolute) added as per qibolab #439.
For now, I tried to not change the expected behaviour of the routines, in particular:
For attenuation sweepers I'm not sure if absolute is the expected behaviour, I never used them
Checklist: