Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent parameters classes to appear in the index #1009

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

alecandido
Copy link
Member

@alecandido alecandido commented Oct 12, 2024

Most of them were already isolated, but for the few which were not the index was completely useless.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  • Compatibility with Qibo modules (Please edit this section if the current pull request is not compatible with the following branches).
    • Qibo: master
    • Qibolab: main
    • Qibolab_platforms_qrc: main

Most of them were already isolated, but for the few which were not the index was completely useless.
@alecandido alecandido force-pushed the noindex-routine-autoclass branch from 3ba88db to 39cd463 Compare October 12, 2024 07:22
Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.54%. Comparing base (6789ac8) to head (39cd463).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1009      +/-   ##
==========================================
+ Coverage   97.52%   97.54%   +0.02%     
==========================================
  Files         123      123              
  Lines        9713     9713              
==========================================
+ Hits         9473     9475       +2     
+ Misses        240      238       -2     
Flag Coverage Δ
unittests 97.54% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@Edoardo-Pedicillo Edoardo-Pedicillo added this to the Qibocal 0.1.1 milestone Oct 14, 2024
@alecandido alecandido added this pull request to the merge queue Oct 15, 2024
Merged via the queue into main with commit 44ec734 Oct 15, 2024
21 checks passed
@alecandido alecandido deleted the noindex-routine-autoclass branch October 15, 2024 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants