Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in asmatrix_fused with CupyBackend #950

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Jun 23, 2023

Closes #928.
This PR works with qiboteam/qibojit#125.
I've added an explicit cast to numpy array to make sure that this method works as expected also on GPU.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (232af91) 100.00% compared to head (d1559aa) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #950   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           49        49           
  Lines         6929      6929           
=========================================
  Hits          6929      6929           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/backends/numpy.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this, looks good to me.

@renatomello renatomello merged commit 05e2d3c into master Jun 26, 2023
@renatomello renatomello deleted the fix_fused branch June 26, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FusedGate.asmatrix breaks if gate appended is gates.Unitary created from a cupy ndarray
3 participants