Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repeated execution #918

Merged
merged 6 commits into from
May 29, 2023
Merged

Fix repeated execution #918

merged 6 commits into from
May 29, 2023

Conversation

vodovozovaliza
Copy link
Contributor

This PR closes issue #917.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@vodovozovaliza vodovozovaliza self-assigned this May 25, 2023
@vodovozovaliza vodovozovaliza added the bug Something isn't working label May 25, 2023
@vodovozovaliza vodovozovaliza added this to the Qibo 0.1.14 milestone May 25, 2023
@vodovozovaliza vodovozovaliza linked an issue May 25, 2023 that may be closed by this pull request
@renatomello renatomello self-assigned this May 25, 2023
@renatomello renatomello requested a review from stavros11 May 25, 2023 15:24
@vodovozovaliza vodovozovaliza requested a review from wilkensJ May 25, 2023 15:34
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (53515a6) 100.00% compared to head (1674430) 100.00%.

❗ Current head 1674430 differs from pull request most recent head 63d42a6. Consider uploading reports for the commit 63d42a6 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #918   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         6593      6586    -7     
=========================================
- Hits          6593      6586    -7     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/backends/numpy.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@renatomello renatomello marked this pull request as ready for review May 26, 2023 03:59
@renatomello renatomello added this pull request to the merge queue May 29, 2023
Merged via the queue into master with commit c5f3a76 May 29, 2023
@renatomello renatomello deleted the repeated_execution branch May 29, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in noisy simulation of circuits with state vectors
3 participants