Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concurrence and entanglement_of_formation to quantum_info.metrics #915

Merged
merged 20 commits into from
Jun 2, 2023
Merged

Add concurrence and entanglement_of_formation to quantum_info.metrics #915

merged 20 commits into from
Jun 2, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented May 24, 2023 •
edited
Loading

This closes #892

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels May 24, 2023
@renatomello renatomello added this to the Qibo 0.1.14 milestone May 24, 2023
@renatomello renatomello self-assigned this May 24, 2023
@codecov
Copy link

codecov bot commented May 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0a84cb2) 100.00% compared to head (500ac2a) 100.00%.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #915   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         6595      6619   +24     
=========================================
+ Hits          6595      6619   +24
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/models/error_mitigation.py 100.00% <ø> (ø)
src/qibo/quantum_info/utils.py 100.00% <ø> (ø)
src/qibo/quantum_info/metrics.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@renatomello
Copy link
Contributor Author

@wilkensJ @vodovozovaliza this is ready

@renatomello renatomello requested a review from wilkensJ May 31, 2023 10:57
@scarrazza scarrazza modified the milestones: Qibo 0.1.14, Qibo 0.1.15 Jun 1, 2023
@renatomello renatomello added this pull request to the merge queue Jun 2, 2023
Merged via the queue into master with commit 76caad2 Jun 2, 2023
@renatomello renatomello deleted the concurrence branch June 2, 2023 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilkensJ wilkensJ wilkensJ approved these changes

@vodovozovaliza vodovozovaliza vodovozovaliza approved these changes

@stavros11 stavros11 Awaiting requested review from stavros11

@AlejandroSopena AlejandroSopena Awaiting requested review from AlejandroSopena

Assignees

@renatomello renatomello

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Qibo 0.1.15
Development

Successfully merging this pull request may close these issues.

Add concurrence and entanglement_of_formation to quantum_info
4 participants
@renatomello @vodovozovaliza @wilkensJ @scarrazza