Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changes to DepolarizingChannel #903

Merged
merged 1 commit into from
May 19, 2023
Merged

Revert changes to DepolarizingChannel #903

merged 1 commit into from
May 19, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented May 18, 2023

Somehow #890 reverted the changes implemented by #889 and we didn't notice. This PR reimplements those changes.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the bug Something isn't working label May 18, 2023
@renatomello renatomello added this to the Qibo 0.1.14 milestone May 18, 2023
@renatomello renatomello self-assigned this May 18, 2023
@renatomello renatomello requested a review from stavros11 May 18, 2023 08:57
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9fad0b6) 100.00% compared to head (1f46cd6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #903   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         6593      6573   -20     
=========================================
- Hits          6593      6573   -20     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/gates/channels.py 100.00% <100.00%> (ø)
src/qibo/models/utils.py 100.00% <100.00%> (ø)
src/qibo/models/variational.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@renatomello renatomello added this pull request to the merge queue May 19, 2023
Merged via the queue into master with commit f8dac7a May 19, 2023
@renatomello renatomello deleted the depol_channel branch May 19, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants