Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identity inherits Gate #895

Merged
merged 5 commits into from
May 15, 2023
Merged

Identity inherits Gate #895

merged 5 commits into from
May 15, 2023

Conversation

vodovozovaliza
Copy link
Contributor

@vodovozovaliza vodovozovaliza commented May 11, 2023

This PR changes qibo.gates.I and qibo.gates.Alignto inherit Gate instead of ParametrizedGate.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@vodovozovaliza vodovozovaliza requested a review from stavros11 May 11, 2023 13:53
@vodovozovaliza vodovozovaliza self-assigned this May 11, 2023
Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you. Let's see if CI passes now that we updated qibojit.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, tests are not passing because the CI is using an earlier version of qibojit, I could reproduce this locally. Tests should pass with the latest qibojit main.

I am not sure how to fix the CI, maybe we should either release a new qibojit or change pyproject.toml to use qibojit from main.

@scarrazza
Copy link
Member

We can make a qibojit release as soon as qiboteam/qibojit#119 is merged.
Does qiboteam/qibojit#119 and qiboteam/qibojit#118 are back compatible with qibo 0.1.13?

@stavros11
Copy link
Member

Does qiboteam/qibojit#119 and qiboteam/qibojit#118 are back compatible with qibo 0.1.13?

Yes, qibo main (0.1.13) tests are passing with current main of qibojit.

@scarrazza
Copy link
Member

scarrazza commented May 12, 2023

@stavros11 I have released qibojit 0.0.10 relaunched the tests here.

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7dca3c3) 100.00% compared to head (7804f7b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #895   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         6525      6524    -1     
=========================================
- Hits          6525      6524    -1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/backends/numpy.py 100.00% <100.00%> (ø)
src/qibo/gates/gates.py 100.00% <100.00%> (ø)
src/qibo/models/circuit.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@renatomello renatomello marked this pull request as ready for review May 15, 2023 08:42
@renatomello renatomello added this pull request to the merge queue May 15, 2023
Merged via the queue into master with commit 05a5684 May 15, 2023
@renatomello renatomello deleted the id_gate branch May 15, 2023 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants