-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Identity inherits Gate
#895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thank you. Let's see if CI passes now that we updated qibojit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, tests are not passing because the CI is using an earlier version of qibojit, I could reproduce this locally. Tests should pass with the latest qibojit main.
I am not sure how to fix the CI, maybe we should either release a new qibojit or change pyproject.toml
to use qibojit from main.
We can make a qibojit release as soon as qiboteam/qibojit#119 is merged. |
Yes, qibo main (0.1.13) tests are passing with current main of qibojit. |
@stavros11 I have released qibojit 0.0.10 relaunched the tests here. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #895 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 6525 6524 -1
=========================================
- Hits 6525 6524 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
This PR changes
qibo.gates.I
andqibo.gates.Align
to inheritGate
instead ofParametrizedGate
.Checklist: