Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy ground state before passing to adiabatic evolution #863

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

stavros11
Copy link
Member

@stavros11 stavros11 commented Apr 25, 2023

Fixes #824. @MatteoRobbiati indeed you are right, it is a qibojit issue.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks.

@scarrazza
Copy link
Member

@MatteoRobbiati please let us know if this works also for you.

@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (87ed54f) 100.00% compared to head (6a8abdf) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #863   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         6370      6370           
=========================================
  Hits          6370      6370           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/models/evolution.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm it works as expected also using the qibojit backend.
Thank you @stavros11!

@scarrazza scarrazza added this pull request to the merge queue Apr 25, 2023
Merged via the queue into master with commit 76a2fcc Apr 25, 2023
@MatteoRobbiati
Copy link
Contributor

MatteoRobbiati commented Apr 25, 2023

Only to be sure it is a problem of mine: is it normal that the execution time of the #824 code requires 1sec using numpy and 2min using qibojit @stavros11?

@stavros11
Copy link
Member Author

Only to be sure it is a problem of mine: is it normal that the execution time of the #824 code requires 1sec using numpy and 2min using qibojit @stavros11?

With @andrea-pasquale we have observed this issue in the past for the NumbaBackend, see for example
#839 (comment)
We suspect something is wrong but we did not investigate. I will try to have a look when I have time. This problem seems to appear only with numba, not cupy.

@stavros11 stavros11 deleted the copygroundstate branch April 25, 2023 14:57
@MatteoRobbiati
Copy link
Contributor

MatteoRobbiati commented Apr 25, 2023

With @andrea-pasquale we have observed this issue in the past for the NumbaBackend, see for example #839 (comment) We suspect something is wrong but we did not investigate. I will try to have a look when I have time. This problem seems to appear only with numba, not cupy.

Ok perfect. I will have a look too with some python profiler.

@renatomello renatomello added this to the Qibo 0.1.14 milestone May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The adiabatic evolution model alters the h0 object when using symbolic hamiltonians
4 participants