Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update bounds keyword docs for CMAES #861

Merged
merged 3 commits into from
Apr 25, 2023
Merged

update bounds keyword docs for CMAES #861

merged 3 commits into from
Apr 25, 2023

Conversation

scarrazza
Copy link
Member

Closes #771.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@scarrazza scarrazza requested a review from stavros11 April 25, 2023 10:32
@scarrazza scarrazza added this to the Qibo 0.1.13 milestone Apr 25, 2023
@scarrazza scarrazza requested a review from scarlehoff April 25, 2023 10:44
Copy link
Contributor

@scarlehoff scarlehoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me it is ok. An error would prompt me to look for the cma documentation (although is not super easy to find) so it fixes my problem.

But maybe it would be good to add an example to the qibo documentation precisely because the cma documentation is not that easy to find…

src/qibo/optimizers.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (87ed54f) 100.00% compared to head (2eb6a61) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #861   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           48        48           
  Lines         6370      6370           
=========================================
  Hits          6370      6370           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/optimizers.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

scarrazza and others added 2 commits April 25, 2023 13:05
@scarrazza scarrazza added this pull request to the merge queue Apr 25, 2023
Merged via the queue into master with commit 864f4aa Apr 25, 2023
@scarrazza scarrazza deleted the cmaebounds branch April 26, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

cma optimizer ignores bounds silently
3 participants