Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagonally_dominant flag to random_stochastic_matrix #836

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Mar 21, 2023

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added the enhancement New feature or request label Mar 21, 2023
@renatomello renatomello added this to the Qibo 0.1.13 milestone Mar 21, 2023
@renatomello renatomello self-assigned this Mar 21, 2023
@renatomello renatomello changed the title Add diagonally_dominant to random_stochastic_matrix Add diagonally_dominant flag to random_stochastic_matrix Mar 21, 2023
@renatomello
Copy link
Contributor Author

Tests are only failing here because of qiboteam/qibocal#280 @scarrazza

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (7945be7) 100.00% compared to head (708782d) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #836   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         5942      5950    +8     
=========================================
+ Hits          5942      5950    +8     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/quantum_info/random_ensembles.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@andrea-pasquale
Copy link
Contributor

Tests are only failing here because of qiboteam/qibocal#280 @scarrazza

Tests should pass now. We solved the issue in qiboteam/workflows#46.

@renatomello
Copy link
Contributor Author

Tests are only failing here because of qiboteam/qibocal#280 @scarrazza

Tests should pass now. We solved the issue in qiboteam/workflows#46.

They are. Thank you.

@renatomello renatomello added this pull request to the merge queue Mar 22, 2023
@renatomello renatomello merged commit 5b0b727 into master Mar 22, 2023
@renatomello renatomello deleted the diagonally_dominant branch March 22, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants