-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test_choi_to_kraus()
randomly crashing
#797
Conversation
Since |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #797 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 97 97
Lines 12894 12894
=========================================
Hits 12894 12894
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This is ready for merge after review @alecandido @andrea-pasquale |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine by me, but are you sure is it okay with increasing the tolerance by a factor of 10?
In particular, if raising tolerance is the chosen solution, a factor of 2 would have been sufficient.
Changed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @renatomello.
Checklist: