Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Depolarizing channel on gpu #769

Merged
merged 1 commit into from
Jan 25, 2023
Merged

Depolarizing channel on gpu #769

merged 1 commit into from
Jan 25, 2023

Conversation

AlejandroSopena
Copy link
Contributor

I updated CUDA and cupy on my machine and I realised that the depolarizing channel raises a TypeError when applying it to density matrix circuits and running them on gpu with qibojit-cupy using the latest version of cupy (cupy-cuda12x). This PR fixes it.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@AlejandroSopena AlejandroSopena added the bug Something isn't working label Jan 22, 2023
@AlejandroSopena AlejandroSopena self-assigned this Jan 22, 2023
@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (cfba10c) compared to base (80139d4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #769   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           94        94           
  Lines        12460     12460           
=========================================
  Hits         12460     12460           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/gates/channels.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scarrazza
Copy link
Member

Thank you @AlejandroSopena. When running tests on GPU, I am getting errors in src/qibo/tests/test_measurements.py. Have you observed this issue too?

@AlejandroSopena
Copy link
Contributor Author

Yes, I can reproduce that issue as well. I have already fixed it and I need to open a PR in qibojit but it seems that I don't have permissions to push.

@scarrazza
Copy link
Member

Thank you. You should have access now.

@AlejandroSopena
Copy link
Contributor Author

Thanks. Fixed in qiboteam/qibojit#101

@scarrazza scarrazza added this to the Qibo 0.1.11 milestone Jan 25, 2023
@scarrazza scarrazza merged commit 980e841 into master Jan 25, 2023
@AlejandroSopena AlejandroSopena deleted the depolarizing_channel branch January 29, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants