-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
example quantum anomaly detection #714
Conversation
for more information, see https://pre-commit.ci
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #714 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 88 88
Lines 11629 11629
=========================================
Hits 11629 11629
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
d5873bf
to
a7bd257
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
I need some help with tests that are not passing. |
From the last crash, seems like you are writing to a folder that does not exist: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this, it is in a good shape for me.
I left in the review some small comments, many of which are really small fixes. I suggest two larger changes:
- Reverse the location of the "How to run an example" section with the theoretical section in
README.md
. I think it's more natural to read the theoretical background and then have in sequence: explanation of how to execute, anticipation of the results to be derived. - Add docstrings in the codes so that the implemented functions are clear when reading.
for more information, see https://pre-commit.ci
64bff4a
to
65c23ee
Compare
for more information, see https://pre-commit.ci
@MatteoRobbiati could you please have another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work.
Some more suggestions follow.
If you like them, you can apply the modifications directly by adding the suggestions I purpose (add sugg on batch and then use the Commit suggestion
button).
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
Co-authored-by: Matteo Robbiati <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the last modifications.
It is ok for me.
I have done a last small fix, now I think it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I have linked the new example in sphinx.
To be completed,
I will add README, tests and .ipynb
Checklist: