Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add iswap gate #707

Merged
merged 2 commits into from
Nov 24, 2022
Merged

add iswap gate #707

merged 2 commits into from
Nov 24, 2022

Conversation

Simone-Bordoni
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@Simone-Bordoni
Copy link
Contributor Author

I don't know if other parts must be edited

@Simone-Bordoni Simone-Bordoni added the enhancement New feature or request label Nov 23, 2022
@Simone-Bordoni Simone-Bordoni linked an issue Nov 23, 2022 that may be closed by this pull request
@Simone-Bordoni Simone-Bordoni self-assigned this Nov 23, 2022
@codecov
Copy link

codecov bot commented Nov 23, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (2606a97) compared to base (5f1c614).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #707   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           88        88           
  Lines        11615     11629   +14     
=========================================
+ Hits         11615     11629   +14     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/models/circuit.py 100.00% <ø> (ø)
src/qibo/backends/npmatrices.py 100.00% <100.00%> (ø)
src/qibo/gates/gates.py 100.00% <100.00%> (ø)
src/qibo/tests/test_gates_gates.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scarrazza
Copy link
Member

@Simone-Bordoni thank you, looks good. The only missing feature is the circuit.draw symbol plot definition.

@scarrazza scarrazza added this to the Qibo 0.2.0 milestone Nov 23, 2022
@scarrazza
Copy link
Member

In particular here:

QASM_GATES = {

@stavros11
Copy link
Member

Thanks @Simone-Bordoni, looks good.

In particular here:

QASM_GATES = {

This is for circuit.to_qasm(). For circuit.draw(), the gate should be added here:

labels = {

I think we should add it in both places. Far draw we should decide on a symbol, qiskit uses ⨂.

@Simone-Bordoni
Copy link
Contributor Author

I have added these parts, for now i have used "i" simbol for the circuit.draw()

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks.

@scarrazza scarrazza merged commit 2f98679 into master Nov 24, 2022
@stavros11 stavros11 deleted the add_iswap branch December 14, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Missing iSWAP gate and some gates documentation
3 participants