-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add iswap gate #707
add iswap gate #707
Conversation
I don't know if other parts must be edited |
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #707 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 88 88
Lines 11615 11629 +14
=========================================
+ Hits 11615 11629 +14
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
@Simone-Bordoni thank you, looks good. The only missing feature is the circuit.draw symbol plot definition. |
In particular here: Line 7 in 7b9ca94
|
Thanks @Simone-Bordoni, looks good.
This is for qibo/src/qibo/models/circuit.py Line 1287 in 7b9ca94
I think we should add it in both places. Far draw we should decide on a symbol, qiskit uses ⨂. |
I have added these parts, for now i have used "i" simbol for the circuit.draw() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks.
Checklist: