-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename matrices.py to npmatrices.py #677
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #677 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 80 80
Lines 10530 10532 +2
=========================================
+ Hits 10530 10532 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I think this broke In order to make it worrk with
to
|
@renatomello this PR was linked to qiboteam/qibojit#92, so please use qibojit main until we release a new version of the code. |
@renatomello yes this PR created incompatibility with previous qibojit versions which was fixed in qiboteam/qibojit#92 (see first post). If you use the latest qibojit master the issue should be fixed without having to manually change something. |
Fixes #673. There is a name collision because
matrices
is the name of a module under backends but also defined in the__init__.py
(see #674 for details). Here I rename matrices.py to npmatrices.py to fix this.Qibojit only works using qiboteam/qibojit#92.
Checklist: