Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename matrices.py to npmatrices.py #677

Merged
merged 5 commits into from
Nov 1, 2022
Merged

Rename matrices.py to npmatrices.py #677

merged 5 commits into from
Nov 1, 2022

Conversation

stavros11
Copy link
Member

@stavros11 stavros11 commented Oct 31, 2022

Fixes #673. There is a name collision because matrices is the name of a module under backends but also defined in the __init__.py (see #674 for details). Here I rename matrices.py to npmatrices.py to fix this.

Qibojit only works using qiboteam/qibojit#92.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (1a555b3) compared to base (8b0e0d4).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #677   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           80        80           
  Lines        10530     10532    +2     
=========================================
+ Hits         10530     10532    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/backends/__init__.py 100.00% <100.00%> (ø)
src/qibo/backends/npmatrices.py 100.00% <100.00%> (ø)
src/qibo/backends/numpy.py 100.00% <100.00%> (ø)
src/qibo/backends/tensorflow.py 100.00% <100.00%> (ø)
src/qibo/tests/test_parallel.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@scarrazza scarrazza self-requested a review November 1, 2022 08:50
@scarrazza scarrazza merged commit c99e296 into master Nov 1, 2022
@scarrazza scarrazza mentioned this pull request Nov 1, 2022
4 tasks
@renatomello
Copy link
Contributor

renatomello commented Nov 4, 2022

I think this broke qibo.set_backend('qibojit').

In order to make it worrk with qibo==0.1.9dev0 and qibojit==0.0.5, I had to manually edit line 5 of my local install of qibojit/backends/matrices.py from

from qibo.backends.matrices import Matrices

to

from qibo.backends.npmatrices import NumpyMatrices as Matrices

@scarrazza
Copy link
Member

@renatomello this PR was linked to qiboteam/qibojit#92, so please use qibojit main until we release a new version of the code.

@stavros11
Copy link
Member Author

@renatomello yes this PR created incompatibility with previous qibojit versions which was fixed in qiboteam/qibojit#92 (see first post). If you use the latest qibojit master the issue should be fixed without having to manually change something.

@scarrazza scarrazza deleted the npmatrices branch November 11, 2022 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dill test is failing
3 participants