Distributed circuit refactoring #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## abstrevol #604 +/- ##
=============================================
+ Coverage 77.26% 86.31% +9.04%
=============================================
Files 86 84 -2
Lines 11997 11885 -112
=============================================
+ Hits 9270 10259 +989
+ Misses 2727 1626 -1101
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
scarrazza
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the distributed circuit (multigpu) as part of the refactoring. Note that since qibotf is removed, this only works with qibojit-cupy backends. Relevant operators were added in #qiboteam/qibojit#81.
Tests are passing on my GPU. I have not tested performance on device with multiple GPUs.
Also note that the distributed circuit and everything related to it cannot be tested in CI which has no GPUs, so coverage will not be 100%, unless we disable the related lines.