Move CPU fallback for frequencies #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I made some tests and the fix is working well, at least with the examples that were not working before. |
|
I also changed the warning log message after @stavros11 suggestion in PR qiboteam/qibojit#54. |
Codecov Report
@@ Coverage Diff @@
## master #527 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 85 85
Lines 12284 12284
=========================================
Hits 12284 12284
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
scarrazza
approved these changes
Dec 23, 2021
|
Can we merge this? |
|
Yes, I believe so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I moved the CPU fallback from
qibo.core.measurements.frequenciestoqibo.core.measurements._calculate_frequencies, so that we call it with arguments and the CPU fallback implemented in PR qiboteam/qibojit#54 converts them, if needed.