Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AAVQE example to doctests #518

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Add AAVQE example to doctests #518

merged 6 commits into from
Nov 22, 2021

Conversation

mlazzarin
Copy link
Contributor

I added the AAVQE example to the doctests, fixed some typos, and removed some hardcoded calls to NumPy methods that make tests crash with CuPy.

@codecov
Copy link

codecov bot commented Nov 22, 2021

Codecov Report

Merging #518 (195520b) into master (fe91300) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #518   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           83        83           
  Lines        11917     11917           
=========================================
  Hits         11917     11917           
Flag Coverage Δ
unittests 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/models/variational.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe91300...195520b. Read the comment docs.

Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@mlazzarin
Copy link
Contributor Author

@scarrazza what's your opinion about keeping the old main example main_old.py. Is it really necessary?

@scarrazza
Copy link
Member

I think this file should be removed.

@scarrazza scarrazza merged commit 0ac5791 into master Nov 22, 2021
@scarrazza scarrazza deleted the fixaavqe branch February 11, 2022 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants