-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make qibojit default backend and update warnings #436
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @stavros11 looks perfect.
Let me suggest to include one sentence about the QIBO_LOG_LEVEL
in the documentation.
Codecov Report
@@ Coverage Diff @@
## qibojit #436 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 83 83
Lines 11867 11865 -2
=========================================
- Hits 11867 11865 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks for the review. I fixed the tests and now everything should work on both CPU and GPU.
Sure, shall we do this in the backend sections that are introduced in #435? In this case I can merge the documentation branch here and update this and also the fact that qibojit is now the default backend. Let me know. Other than that, I believe the qibojit integration is ready. We could try releasing qibojit on pip and adding it to the CI. |
@stavros11 thanks. Please go ahead with the log flag documentation. |
I added a paragraph about the log level environment variable under the list of backends in the Packages section. I also made a few updates in the examples and Backends sections of the docs, as they still contained information about the defaulteinsum/matmuleinsum backends which no longer exist. @scarrazza please have a look in the updates and let me know if you agree. |
@stavros11 thanks, I have included an extra note about cupy installation. |
@stavros11 let me put this info here, I believe we should include a warning message about |
disabling parallel evaluation on darwin
adding qibojit to CI
As discussed in #427 this makes qibojit the default backend if all possible backends are available. The backend order now is the following:
If qibojit and qibotf are not available, a warning will appear prompting the user to install them for increased performance. If one of the two is available no warning will appear. Furthermore an info message will be printed in all cases the first time
qibo
is imported showing the activated benchmarks.The user can control the logging level using the
QIBO_LOG_LEVEL
environment variable. Default value is 1 (everything appears) and additional options are 3 (hide info) and 4 (hide info and warnings). See here for more info on logging levels.As we discussed, my only concern about making qibojit the default is the dry run time. Other than that this PR should be ok.
Note: I noticed that some tests are failing when running on GPU due to some cupy->numpy conversion issues. I will fix this in a different PR, it should not affect what is implemented here.