Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix set_device test for GPU #417

Merged
merged 6 commits into from
May 25, 2021
Merged

Fix set_device test for GPU #417

merged 6 commits into from
May 25, 2021

Conversation

stavros11
Copy link
Member

Fixes #415. It seems that the issue comes from a set_device test that does not reset the device properly back to GPU when it runs for the numpy backend. All tests now work both on CPU and GPU for me. @scarrazza please confirm that it is okay for you too.

@stavros11 stavros11 requested a review from scarrazza May 21, 2021 10:36
Copy link
Member

@scarrazza scarrazza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, looks good to me and works fine on my systems.

@codecov
Copy link

codecov bot commented May 24, 2021

Codecov Report

Merging #417 (be18e6a) into master (3b61c09) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #417   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines        11399     11401    +2     
=========================================
+ Hits         11399     11401    +2     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/tests/test_parallel.py 100.00% <ø> (ø)
src/qibo/parallel.py 100.00% <100.00%> (ø)
src/qibo/tests/test_backends_init.py 100.00% <100.00%> (ø)
src/qibo/tests/test_models_variational.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b61c09...be18e6a. Read the comment docs.

@scarrazza scarrazza merged commit d6e3933 into master May 25, 2021
@stavros11 stavros11 deleted the gputests branch June 4, 2021 09:59
@stavros11 stavros11 restored the gputests branch June 4, 2021 09:59
@stavros11 stavros11 deleted the gputests branch June 27, 2021 17:57
@stavros11 stavros11 restored the gputests branch June 27, 2021 17:57
@stavros11 stavros11 deleted the gputests branch June 27, 2021 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test crashes on GPU
2 participants