Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding version checks for backends #412

Merged
merged 1 commit into from
May 17, 2021
Merged

adding version checks for backends #412

merged 1 commit into from
May 17, 2021

Conversation

scarrazza
Copy link
Member

Implements a simple version check for backends, including the mirroring with setup.py.

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #412 (349dcb0) into bkdocs (bf43f1e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            bkdocs      #412   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           79        79           
  Lines        11398     11399    +1     
=========================================
+ Hits         11398     11399    +1     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/qibo/backends/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf43f1e...349dcb0. Read the comment docs.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the check looks good but only checks the tensorflow version. If I understood correctly your comment here we would also like to check that the qibotf version is compatible with the qibo version.

@@ -2,6 +2,9 @@
from qibo import config
from qibo.config import raise_error, log, warnings

# versions requirements
TF_MIN_VERSION = '2.2.0'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also move this to config.py.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any special reason to move that to config.py?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, other than that we define all other "constants" used throughout the qibo code there. I don't have any strong preference on what is the right position for TF_MIN_VERSION though.

@scarrazza
Copy link
Member Author

I believe the only strong requirement we have now is the tf version, given that for qibotf we don't have any specific API that requires locking their version.

@stavros11
Copy link
Member

I believe the only strong requirement we have now is the tf version, given that for qibotf we don't have any specific API that requires locking their version.

I agree with this, so I guess this should be fine to merge now and if at some point we create some API inconsistency between qibo and qibotf we can use the same template the check the corresponding versions.

@scarrazza scarrazza changed the base branch from bkdocs to simtf May 17, 2021 16:49
@scarrazza
Copy link
Member Author

@stavros11, yes, thanks, I agree.

@scarrazza scarrazza merged commit 08f37e6 into simtf May 17, 2021
@scarrazza scarrazza deleted the checkversion branch July 10, 2021 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants