-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add models.encodings.binary_encoder
for real-valued data
#1551
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1551 +/- ##
=======================================
Coverage 99.67% 99.68%
=======================================
Files 76 76
Lines 11234 11271 +37
=======================================
+ Hits 11198 11235 +37
Misses 36 36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: Stavros Efthymiou <[email protected]>
Co-authored-by: BrunoLiegiBastonLiegi <[email protected]>
@@ -116,8 +116,69 @@ def phase_encoder(data, rotation: str = "RY", **kwargs): | |||
return circuit | |||
|
|||
|
|||
def binary_encoder(data, **kwargs): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you share the reference/the idea you followed here to implement the binary encoding on this way?
Is that an alternative way to implement the "standard" binary encoding by means of controlled rotations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what you mean by "standard", since there are many ways to do binary encoding. This specific one is something that @GoGoKo699 and I have been working on, but it is not published yet. The only difference here is that the amplitudes are parameterized in a specific coordinate system in a
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, just remove the two commented lines pointed out by @MatteoRobbiati and this can be merged by my side.
Co-authored-by: Matteo Robbiati <[email protected]>
Will generalize to complex-valued data in a separate PR soon.
Checklist: