-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transpiler refactor #1500
Merged
Merged
Transpiler refactor #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1500 +/- ##
==========================================
- Coverage 99.72% 99.71% -0.01%
==========================================
Files 80 81 +1
Lines 11783 11737 -46
==========================================
- Hits 11751 11704 -47
- Misses 32 33 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
csookim
commented
Oct 28, 2024
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
alecandido
approved these changes
Nov 25, 2024
stavros11
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This covers issue #1493.
This PR updates the qubit representation in
qibo
to support hardware execution after transpilation.Circuit.wire_names
andGate.qubits
will be used on the hardware side.Terms
Circuit.wire_names: list[str | int]
Gate.qubits: Tuple[int, ...]
nx.Graph
Updates
initial_layout
, which was used to represent the mapping between{physical qubit: logical qubit}
.wire_names
itself serves as the mapping. Qubiti
corresponds to the physical qubit namedwire_names[i]
.Transpiler
connectivity
representing the hardware.connectivity
must match thewire_names
in the circuit.Placer
calculates the placement based onconnectivity
andcircuit
. It updates thewire_names
directly with no return value.Router
does routing based onconnectivity
andcircuit
, returning anew_circuit
andfinal_mapping
.Checklist: