Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in quantum_info.linalg_operations.matrix_power for negative powers of singular matrices #1472

Merged
merged 21 commits into from
Oct 9, 2024
Merged

Fix bug in quantum_info.linalg_operations.matrix_power for negative powers of singular matrices #1472

merged 21 commits into from
Oct 9, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 4, 2024 •
edited
Loading

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added bug Something isn't working quantum_info module PRs and issues related to the quantum information module labels Oct 4, 2024
@renatomello renatomello added this to the Qibo 0.2.13 milestone Oct 4, 2024
@renatomello renatomello self-assigned this Oct 4, 2024
@renatomello renatomello mentioned this pull request Oct 4, 2024
Merged
4 tasks
@codecov Codecov
Copy link

codecov bot commented Oct 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (fa9ee31) to head (2358c3f).
Report is 22 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1472   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          81       81           
  Lines       11800    11820   +20     
=======================================
+ Hits        11792    11812   +20     
  Misses          8        8
Flag Coverage Δ
unittests 99.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello
Copy link
Contributor Author

This is also ready and it is blocking #1470

BrunoLiegiBastonLiegi
BrunoLiegiBastonLiegi reviewed Oct 4, 2024
View reviewed changes
src/qibo/backends/numpy.py Outdated Show resolved Hide resolved
src/qibo/backends/pytorch.py Outdated Show resolved Hide resolved
@renatomello renatomello mentioned this pull request Oct 4, 2024
Merged
stavros11
stavros11 approved these changes Oct 8, 2024
View reviewed changes
src/qibo/backends/numpy.py Outdated Show resolved Hide resolved
@renatomello renatomello added this pull request to the merge queue Oct 9, 2024
Merged via the queue into master with commit 36ed3fe Oct 9, 2024
27 checks passed
@renatomello renatomello deleted the matrix_power branch October 9, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simone-Bordoni Simone-Bordoni Simone-Bordoni approved these changes

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi approved these changes

@stavros11 stavros11 stavros11 approved these changes

@AlejandroSopena AlejandroSopena Awaiting requested review from AlejandroSopena

Assignees

@renatomello renatomello

Labels
bug Something isn't working quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Milestone
Qibo 0.2.13
Development

Successfully merging this pull request may close these issues.
4 participants
@renatomello @stavros11 @BrunoLiegiBastonLiegi @Simone-Bordoni