Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (state) Schmidt decomposition to quantum_info.linalg_operations #1471

Merged
merged 33 commits into from
Oct 16, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Oct 4, 2024

This is the first step to close #1345. However, fully closing it requires implementing the Schmidt decomposition for operators.

EDIT: Needs #1473

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module labels Oct 4, 2024
@renatomello renatomello added this to the Qibo 0.2.13 milestone Oct 4, 2024
@renatomello renatomello self-assigned this Oct 4, 2024
@renatomello renatomello changed the title Add Schmidt decomposition to quantum_info.linalg_operations Add (state) Schmidt decomposition to quantum_info.linalg_operations Oct 4, 2024
@renatomello renatomello changed the base branch from master to svd October 7, 2024 05:15
Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (e7276d8) to head (b7f0de3).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1471   +/-   ##
=======================================
  Coverage   99.93%   99.93%           
=======================================
  Files          81       81           
  Lines       11795    11805   +10     
=======================================
+ Hits        11787    11797   +10     
  Misses          8        8           
Flag Coverage Δ
unittests 99.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello
Copy link
Contributor Author

@Simone-Bordoni I'm using this function to replace another one in the transpiler, so could you please check that everything is ok? Thanks.

@Simone-Bordoni
Copy link
Contributor

@Simone-Bordoni I'm using this function to replace another one in the transpiler, so could you please check that everything is ok? Thanks.

Much better now! Hopefully it should also improve the precision in the different backends.

@renatomello renatomello changed the base branch from svd to master October 8, 2024 11:02
@renatomello renatomello marked this pull request as ready for review October 8, 2024 11:02
src/qibo/quantum_info/entanglement.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/entanglement.py Outdated Show resolved Hide resolved
src/qibo/quantum_info/entanglement.py Outdated Show resolved Hide resolved
@renatomello renatomello added this pull request to the merge queue Oct 16, 2024
Merged via the queue into master with commit 958b11b Oct 16, 2024
25 checks passed
@renatomello renatomello deleted the schmidt branch October 16, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Operator Schmidt Decomposition
3 participants