Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix definition of fidelity in quantum_info.metrics #1463

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Sep 23, 2024

Two different definitions of fidelity were being mixed, one with $\text{Tr}$ and another with $\text{Tr}^{2}$. This PR fixes it.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added bug Something isn't working quantum_info module PRs and issues related to the quantum information module labels Sep 23, 2024
@renatomello renatomello added this to the Qibo 0.2.13 milestone Sep 23, 2024
@renatomello renatomello self-assigned this Sep 23, 2024
@renatomello renatomello changed the title Fix definition of fidelity Fix definition of fidelity in quantum_info.metrics Sep 23, 2024
Copy link

codecov bot commented Sep 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.93%. Comparing base (fee545b) to head (d254f8e).
Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1463      +/-   ##
==========================================
- Coverage   99.94%   99.93%   -0.02%     
==========================================
  Files          81       81              
  Lines       11737    11737              
==========================================
- Hits        11731    11729       -2     
- Misses          6        8       +2     
Flag Coverage Δ
unittests 99.93% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello added this pull request to the merge queue Oct 2, 2024
Merged via the queue into master with commit 677584c Oct 2, 2024
27 checks passed
@renatomello renatomello deleted the fidelity branch October 2, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants