Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix to matrix unpacking in CliffordBackend #1457

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Bugfix to matrix unpacking in CliffordBackend #1457

merged 4 commits into from
Sep 20, 2024

Conversation

BrunoLiegiBastonLiegi
Copy link
Contributor

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi commented Sep 19, 2024 •
edited by renatomello
Loading

Fixes #1453.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@codecov Codecov
Copy link

codecov bot commented Sep 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (df709ce) to head (ea307f9).

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #1457   +/-   ##
=======================================
  Coverage   99.94%   99.94%           
=======================================
  Files          81       81           
  Lines       11708    11709    +1     
=======================================
+ Hits        11701    11702    +1     
  Misses          7        7
Flag Coverage Δ
unittests 99.94% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi mentioned this pull request Sep 19, 2024
Merged
@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi marked this pull request as ready for review September 19, 2024 14:22
AlejandroSopena
AlejandroSopena approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@AlejandroSopena AlejandroSopena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing it so fast @BrunoLiegiBastonLiegi

@renatomello renatomello added this to the Qibo 0.2.12 milestone Sep 20, 2024
@renatomello renatomello added bug Something isn't working quantum_info module PRs and issues related to the quantum information module labels Sep 20, 2024
@renatomello renatomello changed the title Bugfix to matrix unpacking for CliffordBackend Bugfix to matrix unpacking in CliffordBackend` Sep 20, 2024
@renatomello renatomello changed the title Bugfix to matrix unpacking in CliffordBackend` Bugfix to matrix unpacking in CliffordBackend Sep 20, 2024
@renatomello renatomello added this pull request to the merge queue Sep 20, 2024
Merged via the queue into master with commit 4a24b6c Sep 20, 2024
25 checks passed
@renatomello renatomello deleted the clifford_unpack_fix branch September 20, 2024 05:06
@renatomello renatomello restored the clifford_unpack_fix branch September 20, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlejandroSopena AlejandroSopena AlejandroSopena approved these changes

@renatomello renatomello renatomello approved these changes

Assignees

@BrunoLiegiBastonLiegi BrunoLiegiBastonLiegi

Labels
bug Something isn't working quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Milestone
Qibo 0.2.12
Development

Successfully merging this pull request may close these issues.

Error when calculating samples with clifford backend
3 participants
@BrunoLiegiBastonLiegi @renatomello @AlejandroSopena