Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix seed of two tests in quantum_info #1407

Merged
merged 6 commits into from
Aug 2, 2024
Merged

Fix seed of two tests in quantum_info #1407

merged 6 commits into from
Aug 2, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jul 30, 2024

Closes #1405 and #1392

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added bug Something isn't working quantum_info module PRs and issues related to the quantum information module labels Jul 30, 2024
@renatomello renatomello added this to the Qibo 0.2.11 milestone Jul 30, 2024
@renatomello renatomello self-assigned this Jul 30, 2024
@renatomello renatomello requested a review from csookim July 30, 2024 16:02
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (9db9b66) to head (7b085fe).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1407      +/-   ##
==========================================
- Coverage   99.99%   99.94%   -0.05%     
==========================================
  Files          78       78              
  Lines       11222    11222              
==========================================
- Hits        11221    11216       -5     
- Misses          1        6       +5     
Flag Coverage Δ
unittests 99.94% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello changed the title Fix test for quantum_info.process_tomography Fix tests quantum_info Jul 31, 2024
@renatomello renatomello linked an issue Jul 31, 2024 that may be closed by this pull request
@renatomello renatomello changed the title Fix tests quantum_info Fix tests in quantum_info Jul 31, 2024
@renatomello renatomello changed the title Fix tests in quantum_info Fix seed of two tests in quantum_info Jul 31, 2024
@renatomello renatomello marked this pull request as draft July 31, 2024 09:13
@renatomello renatomello marked this pull request as ready for review August 1, 2024 05:25
@csookim csookim removed their request for review August 2, 2024 04:22
@csookim
Copy link
Member

csookim commented Aug 2, 2024

Thank you for your update. I have removed the review request because I think I'm not the most suitable person to review this.

@scarrazza scarrazza added this pull request to the merge queue Aug 2, 2024
Merged via the queue into master with commit 64d78bc Aug 2, 2024
27 checks passed
@scarrazza scarrazza deleted the fix_test branch August 3, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_process_fidelity_and_infidelity() test failed Clifford test failing randomly
5 participants