Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CMA callback #1346

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Fix CMA callback #1346

merged 1 commit into from
Jun 5, 2024

Conversation

andrea-pasquale
Copy link
Contributor

@andrea-pasquale andrea-pasquale commented Jun 5, 2024

CMA callback fixed by calling it for each evaluation and not for each iteartion.
Should fix tests randomly failing, see #1344 for example.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@andrea-pasquale andrea-pasquale added the bug Something isn't working label Jun 5, 2024
@andrea-pasquale andrea-pasquale self-assigned this Jun 5, 2024
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (cb87952) to head (0858afd).

Additional details and impacted files
@@               Coverage Diff               @@
##           sparse_unitary    #1346   +/-   ##
===============================================
  Coverage           99.82%   99.82%           
===============================================
  Files                  72       72           
  Lines               10563    10572    +9     
===============================================
+ Hits                10544    10553    +9     
  Misses                 19       19           
Flag Coverage Δ
unittests 99.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@MatteoRobbiati MatteoRobbiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @andrea-pasquale.

@MatteoRobbiati MatteoRobbiati merged commit 9891ae2 into sparse_unitary Jun 5, 2024
30 checks passed
@scarrazza scarrazza deleted the fix_cma_callback branch June 25, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants