Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dbi gradient combine #1340

Merged
merged 4 commits into from
May 30, 2024
Merged

Dbi gradient combine #1340

merged 4 commits into from
May 30, 2024

Conversation

Sam-XiaoyueLi
Copy link
Contributor

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.
  1. Discard analytical gradient descent functions.
  2. Combine gradient descent strategies into one function gradient_descent in utils_dbr_strategies.py.
  3. Fix notebook errors.
  4. Update tests.

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 94.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 99.19%. Comparing base (c3a149c) to head (0e4d888).
Report is 794 commits behind head on dbi_cost_functions.

Files Patch % Lines
src/qibo/models/dbi/utils_dbr_strategies.py 94.87% 4 Missing ⚠️
src/qibo/models/dbi/utils.py 88.23% 2 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           dbi_cost_functions    #1340      +/-   ##
======================================================
- Coverage               99.26%   99.19%   -0.07%     
======================================================
  Files                      71       75       +4     
  Lines                   10582    10864     +282     
======================================================
+ Hits                    10504    10777     +273     
- Misses                     78       87       +9     
Flag Coverage Δ
unittests 99.19% <94.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sam-XiaoyueLi Sam-XiaoyueLi merged commit a4b52e8 into dbi_cost_functions May 30, 2024
27 of 30 checks passed
@scarrazza scarrazza deleted the dbi_gradient_combine branch June 25, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant