Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose DBI operators #1287

Merged
merged 33 commits into from
Apr 24, 2024
Merged

Expose DBI operators #1287

merged 33 commits into from
Apr 24, 2024

Conversation

Edoardo-Pedicillo
Copy link
Contributor

This PR exposes the operators in DBI class.
Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@Edoardo-Pedicillo Edoardo-Pedicillo changed the title expose operators in DBI Expose DBI operators Mar 28, 2024
@Edoardo-Pedicillo Edoardo-Pedicillo mentioned this pull request Mar 28, 2024
Merged
@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review April 2, 2024 12:11
@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as draft April 2, 2024 12:11
marekgluza
marekgluza requested changes Apr 4, 2024
View reviewed changes
src/qibo/models/dbi/double_bracket.py Outdated Show resolved Hide resolved
src/qibo/models/dbi/double_bracket.py Outdated Show resolved Hide resolved
src/qibo/models/utils.py Show resolved Hide resolved
marekgluza and others added 18 commits April 5, 2024 05:00
@marekgluza
Committing suggestion for the name convention eval_operator -> eval_d…
52c4868 
…br_unitary
@marekgluza
sign conventions on top of the exposed dbr operator
6860a48
@marekgluza
proposed a test of the exposed dbr unitary function
1ebe1c9
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2f55e19 
for more information, see https://pre-commit.ci
@marekgluza
improving the bound implementation
3eb7029
@marekgluza
trivial conflict
3975be0
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
42c1c92 
for more information, see https://pre-commit.ci
@marekgluza
Fixing the type which was already set for a future convention
18517e8
@marekgluza
fixing typo in test file
8cba7ad
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
0e281b4 
for more information, see https://pre-commit.ci
@marekgluza
now the test should run otherwise it entered into 0<0
6871133
@marekgluza
Merge branch 'dbi_fix_gc_sign_conventions' of github.com:qiboteam/qib…
dc2de88 
…o into dbi_fix_gc_sign_conventions
@marekgluza
passing the d argument in the test
34405cb
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
03ca52c 
for more information, see https://pre-commit.ci
@Sam-XiaoyueLi
Remove raise error in test_models_dbi.py
d924465
@Sam-XiaoyueLi
Remove "prints" comment in utils.py
051240e
@Sam-XiaoyueLi
correct sign in eval_dbr_unitaruy (double_bracket.py) - calculate_mat…
09614be 
…rix_exp contains -1j
@marekgluza @andrea-pasquale
Update tests/test_models_dbi.py
f2236cb 
Co-authored-by: Andrea Pasquale <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Apr 9, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.82%. Comparing base (d1bed1d) to head (d9fb54c).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
- Coverage   99.84%   99.82%   -0.02%     
==========================================
  Files          73       73              
  Lines       10693    10699       +6     
==========================================
+ Hits        10676    10680       +4     
- Misses         17       19       +2
Flag Coverage Δ
unittests 99.82% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Edoardo-Pedicillo Edoardo-Pedicillo changed the base branch from fix_import to master April 23, 2024 08:37
@Edoardo-Pedicillo Edoardo-Pedicillo marked this pull request as ready for review April 23, 2024 13:04
andrea-pasquale
andrea-pasquale approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@andrea-pasquale andrea-pasquale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Edoardo-Pedicillo Edoardo-Pedicillo added this pull request to the merge queue Apr 24, 2024
Merged via the queue into master with commit 76bd0f2 Apr 24, 2024
20 of 21 checks passed
@Edoardo-Pedicillo Edoardo-Pedicillo deleted the dbi_fix branch April 24, 2024 06:39
@marekgluza marekgluza mentioned this pull request Jun 3, 2024
Closed
5 tasks
@marekgluza marekgluza restored the dbi_fix branch June 3, 2024 11:44
@marekgluza marekgluza deleted the dbi_fix branch June 4, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrea-pasquale andrea-pasquale andrea-pasquale approved these changes

@marekgluza marekgluza marekgluza approved these changes

@MatteoRobbiati MatteoRobbiati Awaiting requested review from MatteoRobbiati

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Edoardo-Pedicillo @marekgluza @andrea-pasquale @Sam-XiaoyueLi