Fix seed when testing Parameter Shift Rule. #1185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 68 68
Lines 9883 9883
=========================================
Hits 9883 9883
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
renatomello
previously approved these changes
Feb 2, 2024
|
Does fixing the seed using |
renatomello
reviewed
Feb 2, 2024
Oh yes, you are right! Thanks! |
Co-authored-by: Renato Mello <[email protected]>
renatomello
approved these changes
Feb 2, 2024
BrunoLiegiBastonLiegi
approved these changes
Feb 2, 2024
renatomello
changed the title
numpy.random seed when testing Parameter Shift Rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #1181.
Thanks @renatomello for raising the issue. Fixing the random generator seed should prevent such failed tests.
Checklist: