Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create quantum_info.hamming_distance #1159

Merged
merged 13 commits into from
Jan 31, 2024
Merged

Create quantum_info.hamming_distance #1159

merged 13 commits into from
Jan 31, 2024

Conversation

renatomello
Copy link
Contributor

@renatomello renatomello commented Jan 20, 2024

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

@renatomello renatomello added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 20, 2024
@renatomello renatomello added this to the Qibo 0.2.5 milestone Jan 20, 2024
@renatomello renatomello self-assigned this Jan 20, 2024
Copy link

codecov bot commented Jan 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (064ce10) 100.00% compared to head (4ad2bbe) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1159   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        68           
  Lines         9867      9883   +16     
=========================================
+ Hits          9867      9883   +16     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@renatomello renatomello added the quantum_info module PRs and issues related to the quantum information module label Jan 27, 2024
tests/test_quantum_info_utils.py Outdated Show resolved Hide resolved
def hamming_weight(bitstring, return_indexes: bool = False):
def hamming_weight(
bitstring: Union[int, str, list, tuple, np.ndarray], return_indexes: bool = False
):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definition of the weight?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it's in the docstring, I didn't notice it before

@renatomello renatomello added this pull request to the merge queue Jan 31, 2024
Merged via the queue into master with commit b936947 Jan 31, 2024
21 checks passed
@renatomello renatomello deleted the hamming_distance branch January 31, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request quantum_info module PRs and issues related to the quantum information module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants