-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing cupy tests failing #1147
Conversation
@renatomello, I have applied some changes to the
|
@stavros11, I have fixed the issue reported in #1072 by reducing the memory required by the specific test. We had a similar problem back in 2022: we are allocating "many" large objects in the GPU memory and pytest does not give us access to a proper garbage collector, so the cupy driver fails deallocating memory. By reducing the memory the deallocation is faster and the pytest loop (allocation/deallocation) works. I have also fixed a missing casting in
Please let me know if you agree. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1147 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 67 67
Lines 9589 9588 -1
=========================================
- Hits 9589 9588 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
increasing doctest speed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the fixes. Tests are now passing on my computer and the cluster.
Closes #1072 and fixes further cupy failures in the quantum_info module.
Checklist: