Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making VQE tests lighter #1144

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Making VQE tests lighter #1144

merged 6 commits into from
Dec 20, 2023

Conversation

scarrazza
Copy link
Member

This should prevent #1122.

Checklist:

  • Reviewers confirm new code works as expected.
  • Tests are passing.
  • Coverage does not decrease.
  • Documentation is updated.

Copy link
Member

@stavros11 stavros11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I cannot confirm about the issue but tests are also a bit faster now.

@scarrazza
Copy link
Member Author

Thanks @stavros11, but I will keep this open until I identify which backend/setup is generating this issue in the CI.

Copy link

codecov bot commented Dec 20, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1917462) 100.00% compared to head (8fb699e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1144   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           67        67           
  Lines         9589      9589           
=========================================
  Hits          9589      9589           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@scarrazza scarrazza marked this pull request as draft December 20, 2023 19:00
@scarrazza scarrazza added this to the Qibo 0.2.4 milestone Dec 20, 2023
@scarrazza scarrazza marked this pull request as ready for review December 20, 2023 21:54
@scarrazza
Copy link
Member Author

Let me merge this now, I have switched off tensorflow on macos given that it is consuming a large number of resources.

@scarrazza scarrazza merged commit 7e5dee4 into master Dec 20, 2023
21 checks passed
@renatomello renatomello deleted the lighttests branch December 21, 2023 04:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants